Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment with scipy #504

Merged
merged 25 commits into from
Jul 19, 2024
Merged

Alignment with scipy #504

merged 25 commits into from
Jul 19, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented Jul 16, 2024 •
edited
Loading

This PR implements most of EP-03. A few things are postponed to later PRs. The most notable ones is the new bounds interface and setting a default optimizer.

I suggest to start a review with

  • tests/test_deprecations
  • tests/optimagic/optimization/test_scipy_aliases.py
  • src/optimagic/optimization/optimize.py

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@janosg janosg changed the base branch from main to 0.5.0 July 16, 2024 14:06
janosg added 23 commits July 17, 2024 08:23
@janosg
Fix?
44a9e74
@janosg
Add logos to readme.
6a21d6e
@janosg
Basic renaming and deprecations.
c43df7d
@janosg
Fix deprecation warnings in estimation.
8cb3d02
@janosg
Fix remaining deprecation warnings.
6b21ff1
@janosg
Add tests for deprecations.
d781907
@janosg
Add x0 as alias for params.
64cf934
@janosg
Add method as partial alias for algorithm.
a5db76d
@janosg
Fix.
8c34407
@janosg
Add error handling for non-supported and not-yet supported scipy argu…
f24100e 
…ments.
@janosg
Add support for args.
9ae006e
@janosg
Move test file.
fe5bbff
@janosg
Restructure deprecation code.
5e69049
@janosg
Basic renaming and deprecations for convergence and stopping criteria.
5bc1bec
@janosg
Move some default algo options to nag optimizers.
4eda2de
@janosg
Cleanup.
6d366a7
@janosg
Support jac=True and add more tests.
18adaf3
@janosg
Rename some attributes of OptimizeResult.
3e625a4
@janosg
Use | instead of unions in type hints.
282ec42
@janosg
Add aliases.
b5cff07
@janosg
Fix.
e19eb4e
@janosg
Add dict access.
e187142
@janosg
Adjust documentation.
d697cae
@janosg janosg requested a review from timmens July 19, 2024 11:04
timmens
timmens approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work! I think the further alignment with SciPy increases optimagic's user-friendliness (especially for beginners and people who switch from SciPy) dramatically.

I only have a few remarks, but these are minor changes, so I approved already.

CHANGES.md Show resolved Hide resolved
docs/source/how_to/how_to_specify_algorithm_and_algo_options.md Show resolved Hide resolved
src/optimagic/optimization/optimize.py Outdated Show resolved Hide resolved
src/optimagic/optimizers/tao_optimizers.py Show resolved Hide resolved
docs/source/tutorials/optimization_overview.ipynb Outdated Show resolved Hide resolved
@janosg janosg merged commit 5422b09 into 0.5.0 Jul 19, 2024
13 checks passed
@janosg janosg deleted the alignment branch July 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmens timmens timmens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janosg @timmens