-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update infrastructure #507
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I sometimes get this warning when running pre-commits. Maybe you can fix it with your PR warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
- 'extend-ignore' -> 'lint.extend-ignore'
- 'select' -> 'lint.select'
- 'pydocstyle' -> 'lint.pydocstyle'
- 'per-file-ignores' -> 'lint.per-file-ignores' |
for more information, see https://pre-commit.ci
No, having
Yes, we should combine all pre-commit hooks in one folder but the resulting environment files should still stay in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Thanks. Just minor comments.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very nice PR!
PYPI_API_TOKEN_OPTIMAGIC
as secret to repoOpen Questions:
PYPI_API_TOKEN
toPYPI_API_TOKEN_ESTIMAGIC
. In this case we would need to create a new one.-> No
.scripts
to store the python fileupdate-name-in-pyproject.py
. Proposal: Combine contents of.scripts
folder with.envs
folder in new folder called.ci
.-> We will use .tools for everything now
mypy discussion
For now, I have opted to keep both the mypy pre-commit and the mypy GitHub Action task. Given tools like
pre-commit CI
, I see an advantage in not using the development environment for the hooks. However, since we are not entirely sure that this mypy call is doing the same thing that the mypy call from our dev environment is doing, I believe the GitHub Action task is necessary. Combined, we should (1) be able to gain some experience with pre-commit mypy, (2) ideally get quick errors before committing, and (3) be confident that all errors should be caught, at least after pushing.