-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multistart option handling #513
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR.
After you are done with the current comments I will go over the how-to guide; Will be easier to make changes there myself than describing changes in comments.
One more thing: Since it is a breaking change we should convert the multistart_info
dict in the OptimizeResult to a dataclass. You can add a __getitem__
method such that it behaves a bit more like a dict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. We can merge after two mini comments.
In this PR, I update the multistart options handing.
MultistartOptions
data classMultistartInfo
data classMultistartOptions
instead of dictionaries internally"sampling_method"
to"random"
.