Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix results processing of nag optimizers #544

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Fix results processing of nag optimizers #544

merged 4 commits into from
Oct 31, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Oct 28, 2024 •
edited by janosg
Loading

  • Fixes results processing of nag optimizers
  • Wait for DFO-LS fix (opened issue here)

Closes #538

@timmens timmens changed the title Fix #538 Fix results processing of nag optimizers Oct 28, 2024
@timmens timmens mentioned this pull request Oct 28, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/optimagic/optimizers/nag_optimizers.py 93.30% <100.00%> (+1.47%) ⬆️

janosg
janosg approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@janosg janosg merged commit cc049d1 into main Oct 31, 2024
17 checks passed
@janosg janosg deleted the dfols-at-optimum branch October 31, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosg janosg janosg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Result processing crashes if DFOLS starts from optimum
2 participants
@timmens @janosg