Run tests daily and with all supported python versions #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
approved these changes
Aug 23, 2023
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.8] | ||
| python-version: [3.8, 3.9, '3.10', 3.11] |
There was a problem hiding this comment.
Not sure of the syntax, but do the single quote actually do sth or should this be the same for all versions?
Suggested change
| python-version: [3.8, 3.9, '3.10', 3.11] | |
| python-version: [3.8, 3.9, 3.10, 3.11] |
There was a problem hiding this comment.
Yep, the quotes make it a string. Otherwise YAML interprets it as a double and will read 3.1 instead of 3.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the tests pass in all currently supported python versions (3.8 - 3.11). Also, since some dependencies like Ax seem to sometimes have breaking changes, the tests will now run daily to make sure we catch any issues with new releases of dependencies.