Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid pydata theme warning #130

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Avoid pydata theme warning #130

merged 2 commits into from
Oct 25, 2023

Conversation

AngelFP
Copy link
Member

@AngelFP AngelFP commented Oct 25, 2023 •
edited
Loading

The latest version of the theme raises a warning if navigation_with_keys is not explicitly set, which causes readthedocs to report a failed build. This PR simply sets it to the new default.

MaxThevenet
MaxThevenet approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AngelFP AngelFP merged commit 3fefc7f into main Oct 25, 2023
10 checks passed
@AngelFP AngelFP deleted the avoid_pydata_theme_warning branch October 25, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngelFP @MaxThevenet