Fix bug with parameter type in Ax generators #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #150, where the
dtype
of theVaryingParameters
was not being used by the Ax Service generators. The type was therefore being inferred by Ax, which sometimes would set a float as an int.It also fixes an issue where parameters with a dtype other than float would crash the exploration.
The tests have been updated to prevent a random crash in the new test introduced in #150.