-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Ax optional #156
Make Ax optional #156
Conversation
for more information, see https://pre-commit.ci
… into remove_ax_dependency
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RemiLehe . Could you have a look at the comments? It would also be good to reflect this change in the docs.
@@ -24,7 +24,6 @@ classifiers = [ | |||
dependencies = [ | |||
'libensemble @ git+https://github.com/Libensemble/libensemble@develop', | |||
'jinja2', | |||
'ax-platform >= 0.3.4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add pandas
here? It is not only needed for testing.
Co-authored-by: Ángel Ferran Pousa <angel.ferran.pousa@desy.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AngelFP Awesome, thanks a lot! I updated the Perlmutter instructions. Feel free to merge the PR :) |
Great! I'll merge as soon as the tests are done. |
Fix the readme so it installs all dependencies by default. Follow-up to optimas-org#156.
Fix the readme so it installs all dependencies by default. Follow-up to optimas-org#156. Use recommended/best practice pip syntax (as a module).
Fix the readme so it installs all dependencies by default. Follow-up to optimas-org#156. Use recommended/best practice pip syntax (as a module).
This PR removes
ax-platform
from the dependencies ofoptimas
, since this can be quite a heavy dependency (but addspandas
which, as it turns out, was a hidden dependency ofoptimas
).The user will get an error telling them to install
ax-platform
whenever they try to instantiate an Ax-based generator, but Ax is not installed: