Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evaluation timeout and improve handling of evaluations that failed to launch #164

Merged
merged 10 commits into from
Feb 5, 2024

Conversation

AngelFP
Copy link
Member

@AngelFP AngelFP commented Jan 12, 2024

This PR adds a new timeout option to the TemplateEvaluator that will kill an evaluation if its runtime reaches this value. It also adds better handling of evaluations that failed to be launched, which are now properly labeled as failed by using the new polling_loop from Libensemble/libensemble#1229.

@AngelFP AngelFP requested review from shuds13 and jlnav January 12, 2024 09:39
@AngelFP AngelFP added the enhancement New feature or request label Jan 15, 2024
pyproject.toml Outdated
@@ -22,7 +22,7 @@ classifiers = [
'Programming Language :: Python :: 3.11',
]
dependencies = [
'libensemble @ git+https://github.com/Libensemble/libensemble@develop',
'libensemble @ git+https://github.com/Libensemble/libensemble@fixes/various_fixes_optims',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch was merged into develop

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated now.

pyproject.toml Outdated Show resolved Hide resolved
@AngelFP AngelFP merged commit c354790 into main Feb 5, 2024
8 checks passed
@AngelFP AngelFP deleted the feature/add_timeout branch February 5, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants