-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for constraints in Ax generators using the Service API #170
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Angel. It looks good!
@@ -74,9 +76,14 @@ def test_ax_single_fidelity(): | |||
var1 = VaryingParameter("x0", -50.0, 5.0) | |||
var2 = VaryingParameter("x1", -5.0, 15.0) | |||
obj = Objective("f", minimize=False) | |||
p1 = Parameter("p1") | |||
|
|||
gen = AxSingleFidelityGenerator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constraint parameter capabilities were also added to AxMultiFidelityGenerator
.
Don't you want to add a test for this too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Apparently the multi-fidelity generator does not accept parameter_constraints
(see facebook/Ax#1639), so I removed them. I updated the tests to include outcome_constraints
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! Thanks!
They are currently not supported by the KG acquisition function.
Adds the possibility of providing
parameter_constraints
andoutcome_constraints
in the generators that use the Ax Service API.Example: