Fix bug when loading AxClient from json and require Ax >= 0.3.5
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
AngelFP
commented
Apr 20, 2024
| @@ -171,9 +171,7 @@ def _tell(self, trials: List[Trial]) -> None: | |||
| current_step = generation_strategy.current_step | |||
| # Reduce only if there are still Sobol trials left. | |||
| if current_step.model == Models.SOBOL: | |||
| current_step.num_trials -= 1 | |||
There was a problem hiding this comment.
This is the actual fix. Just removing this line.
The rest of the changes are simply due to requiring Ax > 0.3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where an AxClient could not be loaded from a json file because the SOBOL step had
num_trials = 0. The fix is trivial (single line) if we require Ax >= 0.3.5.