Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose precedent and extra_args in TemplateEvaluator #216

Merged
merged 2 commits into from
May 30, 2024

Conversation

AngelFP
Copy link
Member

@AngelFP AngelFP commented May 24, 2024

  • The precedent option allows the user to specify a string that precedes the executable in the mpi command. When running a python script, libEnsemble sets this precedent to the absolute path of the python interpreter by default. We observed that this can be an issue if the script needs to be executed in a different python environment provided by env_script (Unable to run a .py template with a different python environment #214). Allowing the user to change the default behavior fixes this issue.
  • The extra_args allow the user to pass additonal arguments to the mpi command. This is a feature we used to expose in libe_opt (through an environment variable) but that was lost in the transition to optimas.
  • I also did some refactoring to simplify the sim_function.

@AngelFP AngelFP requested review from shuds13 and jlnav May 24, 2024 10:25
@AngelFP AngelFP changed the title Expose precedent and extra_args in TemplateEvaluator. Expose precedent and extra_args in TemplateEvaluator May 24, 2024
@AngelFP AngelFP added the enhancement New feature or request label May 24, 2024
Copy link
Collaborator

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out changes. Work fine.

@AngelFP AngelFP merged commit 9e48782 into main May 30, 2024
6 checks passed
@AngelFP AngelFP deleted the feature/new_template_evaluator_options branch May 30, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants