exception type and other util #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapeBaBa
reviewed
Aug 12, 2023
hildr-utilities/src/main/java/io/optimism/utilities/derive/stages/Batch.java
Show resolved
Hide resolved
hildr-utilities/src/main/java/io/optimism/utilities/derive/stages/Frame.java
Show resolved
Hide resolved
hildr-utilities/src/main/java/io/optimism/utilities/digest/BytesUtil.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @author thinkAfCod | ||
| * @since 0.1.1 | ||
| */ | ||
| public class CompressorFactory { | ||
| public class RandomUtil { |
hildr-utilities/src/main/java/io/optimism/utilities/ex/UnsupportedException.java
Outdated
Show resolved
Hide resolved
| * @param channelId channelId | ||
| * @param frameNumber channel frame number | ||
| */ | ||
| public record TxData(byte[] data, byte[] channelId, int frameNumber) { |
There was a problem hiding this comment.
这个是frame变了一个形式，可直接使用Frame，已移除
| * either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
包名不要缩写，另外exception不用都放一块，除非是会共用的
There was a problem hiding this comment.
好的，这个是公共的，不同的包内都会使用
| if (p.length > avail) { | ||
| readLen = avail; | ||
| } | ||
| System.arraycopy(data, pos, p, 0, readLen); |
There was a problem hiding this comment.
可以用arrayUtils或者arrays简化下代码吧，你看下node里面的batches
There was a problem hiding this comment.
这里需要把数据填充到参数里的byte[]里。
ArrayUtils和Arrays工具都是返回一个新创建的数组，没办法替换System.arraycopy这个操作。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exception type and util