Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added "enabled" field to decision metadata structure. #376

Merged
merged 1 commit into from
Nov 18, 2020
Merged

feat: added "enabled" field to decision metadata structure. #376

merged 1 commit into from
Nov 18, 2020

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • added "enabled" field to decision metadata structure
  • setting "enabled" to true for activate() since we check for non nil variation.

@coveralls
Copy link

coveralls commented Nov 10, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 98.785% when pulling a88414b on yasir/added_enabled_to_metadata into abf9b23 on master.

@msohailhussain msohailhussain marked this pull request as ready for review November 18, 2020 22:09
@msohailhussain msohailhussain requested a review from a team as a code owner November 18, 2020 22:09
msohailhussain
msohailhussain approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jaeopt
jaeopt approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 87e902a into master Nov 18, 2020
@jaeopt jaeopt deleted the yasir/added_enabled_to_metadata branch November 18, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yasirfolio3 @coveralls @msohailhussain @pawels-optimizely @jaeopt