fix(handler-registry-service): add support for multiple clients #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix datafile handler sync with atomic dictionary cleanup clean up
|
|
||
| class LoggerTests_MultiClients: XCTestCase { | ||
|
|
||
| override func setUpWithError() throws { |
There was a problem hiding this comment.
Can we add base class and put these two overrided methods in there and extend classes from that base class. I see these two methods at many locations.
There was a problem hiding this comment.
Most test cases will use own tasks in these methods. I'll clean up these empty methods.
msohailhussain
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handler-registry-service to support multiple clients (sdkKeys).