Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ats): add configurable timeouts for ODP segment fetch and event dispatch #471

Merged
merged 12 commits into from
Dec 16, 2022
Merged

feat(ats): add configurable timeouts for ODP segment fetch and event dispatch #471

merged 12 commits into from
Dec 16, 2022

Conversation

jaeopt
Copy link
Collaborator

@jaeopt jaeopt commented Dec 5, 2022

Summary

Timeouts for ODP segment fetch and event dispatch are configurable. Default value is 10 secs.

Test plan

  • Unit tests validating configurable timeouts in secs.
  • Unit tests validating default 10 secs.

Issues

  • FSSDK-8684

@jaeopt jaeopt requested a review from a team as a code owner December 5, 2022 23:30
@jaeopt jaeopt changed the base branch from master to jae/ats-2 December 5, 2022 23:32
@jaeopt jaeopt changed the title feat(ATS): add configurable timeouts for ODP segment fetch and event dispatch feat(ats): add configurable timeouts for ODP segment fetch and event dispatch Dec 5, 2022
Base automatically changed from jae/ats-2 to master December 16, 2022 19:18
msohailhussain
msohailhussain approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit ce163d0 into master Dec 16, 2022
@jaeopt jaeopt deleted the jae/ats-timeout branch December 16, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaeopt @msohailhussain