Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove demanding dependency fast_yaml #3

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

almirsarajcic
Copy link
Member

There were some complaints that :fast_yaml couldn't compile for some users. I've investigated the issue, but couldn't find an alternative as there's no native YAML encoder in Elixir/Erlang. Now that we have native JSON implementation, who knows...

Anyway, I didn't spend much time on that until I got the same issue. Of course, this time I've had to find a solution. So, after again wasting a couple of hours trying to set up :fast_yaml dependency and searching for an alternative, I finally decided to write my own YAML encoder. I didn't need to support everything YAML has to offer. I guess that laziness was also one of the reasons behind GitHub's insufficient support of the YAML standard which forced me to create this generator in the first place 😁

I'm not proud of this code, but at least it works™. And it's closer to GitHub's examples than the version that uses :fast_yaml.

Also, this fixes #2.
Now it's possible to have pull_request: instead of pull_request: [].
Look at:

on:
pull_request:
push:
branches:
- main

Linter didn't complain about the newly generated ci.yml file and Prettier didn't find anything to change.

@almirsarajcic almirsarajcic merged commit 9474171 into main Jun 21, 2024
17 checks passed
@almirsarajcic almirsarajcic deleted the remove_fast_yaml branch June 21, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to generate an empty object for workflow_dispatch?
1 participant