Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LICENSE file #200

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Add LICENSE file #200

merged 1 commit into from
Jul 27, 2023

Conversation

not522
Copy link
Member

@not522 not522 commented Jul 25, 2023

Motivation

Since optuna-examples is a split from Optuna, we need to put the same license file as the original.

Description of the changes

  • Add LICENSE file

@toshihikoyanase
Copy link
Member

@Alnusjaponica Could you review this PR, please? As mentioned by the author, this repository should follow the MIT license like optuna/optuna.
c.f., https://github.com/optuna/optuna/blob/b9a2fec629e27a6f97c74879f430265c83ec27b2/LICENSE#L1-L21

@toshihikoyanase toshihikoyanase added the other Issue/PR that does not fit into any other label. label Jul 26, 2023
Alnusjaponica
Alnusjaponica approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the license sentence is exactly the same as optuna/LICENSE. LGTM.

@Alnusjaponica Alnusjaponica removed their assignment Jul 27, 2023
@Alnusjaponica
Copy link
Collaborator

@toshihikoyanase Could you merge this PR?

@toshihikoyanase
Copy link
Member

Thank you for your prompt action. I'll merge this PR.

@toshihikoyanase toshihikoyanase merged commit a0afcb4 into optuna:main Jul 27, 2023
1 check passed
@toshihikoyanase toshihikoyanase added this to the v3.3.0 milestone Jul 27, 2023
@not522 not522 mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alnusjaponica Alnusjaponica Alnusjaponica approved these changes

Assignees
No one assigned
Labels
other Issue/PR that does not fit into any other label.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@not522 @toshihikoyanase @Alnusjaponica