Revert "Temporarily constraint to xgboost<1.0.0".
#954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an accidental f-string" This reverts commit bb48c47.
smly
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
• Verified that pip install xgboost try to install xgboost-1.0.1.
• Verified that xgboost-1.0.1 resolved dmlc/xgboost#5328.
LGTM. Thank you!
toshihikoyanase
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
LGTM. Thank you.
[notes]
I checked by using python:3.5 docker image, and I found that examples/pruning/xgboost_cv_integration.py caused the following error if I did not install pandas. In the CI jobs, pandas is always installed with xgboost, and I don't think this is an issue.
[W 2020-02-25 12:08:40,676] Setting status of trial#0 as TrialState.FAIL because of the following error: AttributeError("'list' object has no attribute 'values'",)
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/optuna/study.py", line 569, in _run_trial
result = func(trial)
File "xgboost_cv_integration.py", line 51, in objective
mean_auc = history['test-auc-mean'].values[-1]
AttributeError: 'list' object has no attribute 'values'
|
Regarding the note, we could also update the example to always return a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bb48c47 (#948) as xgboost has been fixed.