Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Reddit Gifts #204

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Update Reddit Gifts #204

merged 1 commit into from
Feb 13, 2017

Conversation

stuartpb
Copy link
Member

No description provided.

@stuartpb
Copy link
Member Author

stuartpb commented Feb 13, 2017 •
edited
Loading

Stray observations:

  • state becomes "other state / province" when country is not US
  • registration has an optional phone number input
  • also an optional showable "special shipping instructions"
  • valid countries include... "USSR (former)"?
  • activating the account requires both an email address confirmation and reddit account association (via link which connects via api) - I think only the Reddit one stops you from navigating the site
  • emails don't seem to be going out so well right now so I couldn't profile any of that
  • settings claim that changing your email will prohibit you from changing anything else. I didn't strictly encounter that, but it's entirely plausible

@stuartpb stuartpb merged commit 0c56771 into master Feb 13, 2017
@stuartpb
Copy link
Member Author

D'oh, I'm getting emails now, so I might as well profile the reset stuff.

@stuartpb stuartpb mentioned this pull request Feb 25, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stuartpb