Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makerbot #217

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Update Makerbot #217

merged 1 commit into from
Feb 15, 2017

Conversation

stuartpb
Copy link
Member

No description provided.

@stuartpb
Copy link
Member Author

Stray observations:

registration form

reset password request form

  • has two "Or, go back to login" links, one for Makerbot's login form and one for Thingiverse, probably due to sloppiness in the template (the one on Thingiverse only has the Thingiverse link)
  • requesting a second password reset token invalidates the previous one

reset password email

  • yes, requesting from makerbot.com sends the email from thingiverse.com, too - and they both link to a page on makerbot.com

reset password change form

  • username is displayed on the page
  • destination is the main page of Thingiverse (https://www.thingiverse.com/), where you are logged in
  • does not reject all-spaces password

change password form

  • going to accounts.makerbot.com when logged in from Thingiverse (after password reset) logs you into makerbot.com, slowly (or maybe you're already logged in and there's just a slow spinner on page load for no reason?)
  • all the labels on the form say they're for username, probably some sloppy copy+pasting in the template
  • there's a similar page on Thingiverse that has the username in the URL
  • I set the password to a 9000-character one, which was accepted, then I tried changing the password with an additional character appended to the "old password" and it was accepted, so they're probably not using the whole thing (bcrypt?)

@stuartpb stuartpb merged commit 9673c3a into master Feb 15, 2017
@stuartpb stuartpb deleted the makerbot branch February 15, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant