Oqtane.Migrations -> Oqtane.Database.Migrations

[hishamco]

@cnurse just moved Migrations to proper namespace which is make sense while the migrations are database related. I tested a new installation after this change to make sure nothing is broken

[sbwalker]

@hishamco this looks fine to me... but I will let @cnurse weigh in before I merge

[cnurse]

The first commit (Interfaces) I believe will be superceded by my bigger PR which converts database projects to build to installable packages per @sbwalker.
I am not sure about the second commit. If all you are doing is changing the namespace then I disagree as the Namespace will no longer map to the folder structure, which is a Best Practise.

[sbwalker]

@hishamco I am going to close this as it appears #1383 replaces it

[hishamco]

I revise the new updates? the migrations are still on its own namespace not Database one

[sbwalker]

I would prefer to leave the namespaces as is

[hishamco]

Ok, one more thing why there's a dependency on Sqlite on the server projects, are there some changes last few weeks?

[hishamco]

FYI I'm unable to install Oqtane, "Value cannot be null. (Parameter 'type')" show up?

[sbwalker]

@hishamco install on which database? You are sure your appsettings.json is in the correct form? There have been a lot of changes to appsettings.json for 2.1

[hishamco]

{
  "Runtime": "Server",
  "Database": {
    "DefaultDBType": "Oqtane.Database.SqlServer.SqlServerDatabase, Oqtane.Database.SqlServer"
  },
  "ConnectionStrings": {
    "DefaultConnection": ""
  },
  "Installation": {
    "DefaultAlias": "",
    "HostPassword": "",
    "HostEmail": "",
    "SiteTemplate": "",
    "DefaultTheme": "",
    "DefaultContainer": ""
  },
  "Localization": {
    "DefaultCulture": "en"
  },
  "AvailableDatabases": [
    {
      "Name": "LocalDB",
      "ControlType": "Oqtane.Installer.Controls.LocalDBConfig, Oqtane.Client",
      "DBType": "Oqtane.Database.SqlServer.SqlServerDatabase, Oqtane.Database.SqlServer"
    },
    {
      "Name": "SQL Server",
      "ControlType": "Oqtane.Installer.Controls.SqlServerConfig, Oqtane.Client",
      "DBType": "Oqtane.Database.SqlServer.SqlServerDatabase, Oqtane.Database.SqlServer"
    },
    {
      "Name": "SQLite",
      "ControlType": "Oqtane.Installer.Controls.SqliteConfig, Oqtane.Client",
      "DBType": "Oqtane.Database.Sqlite.SqliteDatabase, Oqtane.Database.Sqlite"
    },
    {
      "Name": "MySQL",
      "ControlType": "Oqtane.Installer.Controls.MySQLConfig, Oqtane.Client",
      "DBType": "Oqtane.Database.MySQL.MySQLDatabase, Oqtane.Database.MySQL"
    },
    {
      "Name": "PostgreSQL",
      "ControlType": "Oqtane.Installer.Controls.PostgreSQLConfig, Oqtane.Client",
      "DBType": "Oqtane.Database.PostgreSQL.PostgreSQLDatabase, Oqtane.Database.PostgreSQL"
    }
  ]
}

I didn't change anything

[sbwalker]

The only thing which seems to be missing is:

"RenderMode": "ServerPrerendered",

[hishamco]

Same thing, I will try to git fetch again

[sbwalker]

Good question about the SQLite dependency - I will follow up with cnurse. I just tried an install on LocalDB with the latest dev branch and it worked fine.

[hishamco]

Last thing seems the data providers project have been removed, so where can I find the implementation for them?

[sbwalker]

There is a Oqtane.Databases.sln which contains all the database projects. The repo contains all of the data providers in the same location as previously.

[hishamco]

The repo contains all of the data providers in the same location as previously.

Could you please point me to the repo?

[sbwalker]

they are in the main repo: https://github.com/oqtane/oqtane.framework you can see the folders for Oqtane.Database.MySQL, Oqtane.Database.PostgreSQL, etc...

[hishamco]

Seems the internet issue causes some git issue the repo still not fetched totally .. thanks a lot

[sbwalker]

To answer the question on SQLite...

SQLite has "runtimes" dependencies which are not loaded automatically by the AssemblyLoadContext Load methods. This is a known issue see:

dotnet/runtime#13015
dotnet/runtime#3660
dotnet/runtime#3659

The simplest solution for this problem was to add a Nuget Package reference to Oqtane.Server to ensure that the dependency graph is correct. The downside is that Sqlite “core” components are always deployed to the /bin whether or not they are actually used - but this is an acceptable compromise in order to enable this database.

[hishamco]

Are other database providers loaded on demand?

[sbwalker]

Yes, all database providers are deployed and loaded on demand.

[hishamco]

Strange!! I will have a look to SQLite and see why it can't be loaded

[sbwalker]

I am not concerned about this... I am fine releasing 2.1 with this configuration.