Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Template Updated #2005

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Theme Template Updated #2005

merged 2 commits into from
Feb 18, 2022

Conversation

leigh-pointer
Copy link
Contributor

Bootstrap reference updated to 5.1.3

@sbwalker
Copy link
Member

Is there a reason why we should not use the same CDN as the existing themes in the framework:

    new Resource { ResourceType = ResourceType.Stylesheet, Url = "https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.1.3/css/bootstrap.min.css", Integrity = "sha512-GQGU0fMMi238uA+a/bdWJfpUGKUkBdgfFdgBm72SUQ6BeyWjoY/ton0tEjH+OSH9iP4Dfh+7HM0I9f5eR0L/4w==", CrossOrigin = "anonymous" },

    new Resource { ResourceType = ResourceType.Script, Bundle = "Bootstrap", Url = "https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.1.3/js/bootstrap.bundle.min.js", Integrity = "sha512-pax4MlgXjHEPfCwcJLQhigY7+N8rt6bVvWLFyUMuxShv170X53TRzGPmPkZmGBhk+jikR8WBM4yl7A9WMHHqvg==", CrossOrigin = "anonymous" }

@leigh-pointer
Copy link
Contributor Author

The CDN for Bootstrap is the same as what is used in the Oqtane Theme, or have i missed something?

@leigh-pointer
Copy link
Contributor Author

I see it now. I will fix.

@sbwalker sbwalker merged commit a2417bb into oqtane:dev Feb 18, 2022
@leigh-pointer leigh-pointer deleted the BootstrapUpdate branch February 23, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants