Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Registration to display the Password requirments #2697

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Modified Registration to display the Password requirments #2697

merged 3 commits into from
Mar 28, 2023

Conversation

leigh-pointer
Copy link
Contributor

Generating a password can generate a lot of errors and leading to frustration when trying to Register on an Oqtane site. This is manly due to the visitor not knowing the Password Requirements. This has been addressed in this PR.

The Password requirements are now displayed to the visitor.

image

@sbwalker
Copy link
Member

@leigh-pointer I agree that it is helpful to provide the user with more information related to password complexity requirements. My preference would be for this information to be included in the HelpText of the Password label - however I am not sure of the technical feasibility of including dynamic text in this property. As an alternative I am wondering if the password information could be included in the same ModuleMessage which includes the "Please Note That Registrations Requires..." text?

@leigh-pointer
Copy link
Contributor Author

Im on it! Wait for new or updated PR

@leigh-pointer
Copy link
Contributor Author

@sbwalker is this better?

image

To be honest, the message about the password should be visible at all times.
@thabaum
Copy link
Contributor

thabaum commented Mar 27, 2023

As discussed Tool-tips and Validation error messages generally fits all registration form requirement which may make this redundant?

I think improving some nicer modal popups for the entire framework help tool-tips would something to consider a focus if this is not adequate. In areas like this form to help explain what is needed to register keeping a completely uniform look and feel with direct messages maybe there are some things that can be enhanced adding some dynamic engineering to Oqtane.

Usually this stuff is pretty straight forward now days. And you might even create a step-by-step process to enhance the application for on-boarding directing users to entirely different page of components.

If username is email address then the instructions can change.

Username requirements need to be in that message as well. This will make it bigger on loading for small screen devices.

Can we enable/disable this feature in the Registration form as well? Disable it for screens smaller than certain size? Maybe a BIG question mark at the top a user can over or click for a modal? So many possibilities ;)

Screen space is what I take into consideration. I think the form should not be any wider than few characters longer than the longest input you can enter to fix how wide the entire form is to keep it looking. I would call that a plus on all edit forms. I dont care for ultra wide forms for a password I think it looks horrible. The longest thing is the email... forms fields i think should not be wider than this.

To be more direct with your message if you did create it maybe something like:

Requirements:
Email Verification Process
Username must be: [ option 1 ], [ option 2 ],etc... and [ last option if more than one ]
Password must be: [ option 1 ], [ option 2 ],etc... and [ last option if more than one ]

If a an email verification process next page "We sent you a code to verify your [ email or phone number ] please enter it below: Resend Code (please wait [ Wait Time ] minutes."

Again if options are enabled otherwise keep it clean yet function with industry standard best practices and let developers go from there. Options are cool to display how you can make certain features enhance the core features for ideas towards the framework you maybe using Oqtane for as a base.

It would be nice to see a class of modules supported and sold on Oqtane network that is check (pays to be checked) to have all code comply with Oqtane standards. Then we would know if we are dealing with a vendor that actually keeping the project or just throwing it out there as something to buy and use.

Anyhow...

With form validation messages shown when typed wrong along with tool tips makes it hard to want to add more so I would like to see a switch added for this as I can see how people would maybe like this for their users. Help Modals improved always a great idea if uniform across the framework.

Is this something community suggested to fix others issues getting users registered I am not aware of?

@thabaum
Copy link
Contributor

thabaum commented Mar 28, 2023

As another idea, could we maybe put a way to put tool-tip modal popups into the title with a larger question mark to click that pops up all instructions of a module maybe it can even hold FAQs, make this available for any module to be placed in next to the title or anywhere you wish for it to be in that same module component. Module Modal Popup feature you can set the information, instructions or FAQ's without taking up another line of the screen?

@sbwalker sbwalker merged commit 36ecc55 into oqtane:dev Mar 28, 2023
@leigh-pointer leigh-pointer deleted the PwdConstra branch August 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants