Module Creator Owner/Name + Notification Help Text Includes Warning Not To Use The Word "Oqtane". Fixes #3597 #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thabaum
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3597
This PR adds the information to the help text and notification to not use module owner or names that contain the word "oqtane".
It should help resolve issues as shown in #3597 while trying to create a module with a module name that contains "Oqtane" word in it.
This would need to be edited to inform the module name and owner is not allowed to start with the word "Oqtane" if current modifications being tested allow this without experiencing namespace conflicts in the framework itself. This is being discussed in #3597
Additional Context Relating To Documentation:
Another option to help enhance on-boarding module creators in this area is to have a link to Oqtane Module Creator Documentation for additional online support. I have an enhanced documentation outline proposed that would have a place to put a page or section dedicated to module development. This could also explain what you can/can't do such as using the word "oqtane" for module owner and name along with the best practices mentioned in #3597 for Oqtane Module Developers.
I can edit this PR for any updates to be merged relating or you may close this and rewrite things as needed if works best.
Cheers!