Fixes: #3723 - Fix refresh() unnecessary conditional check for page values #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thabaum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updates the if statement to not perform an unnecessary check for page values
Related Issue
Testing Done
Cancel button no longer throws an exception.
Additional Context
Maybe this page logic
&& Utilities.IsPageModuleVisible(page.EffectiveDate, page.ExpiryDate)was meant in another if statement of the parent if statement logic instead of the else statement which page is null?if (page != null)One other note is PR #3726 edits this same file. So it might be best to merge that first then we can redo this commit. Whatever works.