Cleanup module definitition service namespaces #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This pull request cleans up unused namespaces in the Oqtane.Client project
Services\ModuleDefinitionService.csandServices\Interfaces\IModuleDefinitionService.csfiles.Testing Performed
Oqtane Framework was able to build and run as expected after these namespaces where removed with the related functionality behavior being reviewed.
Screenshots
Before:
After:
Testing:
Additional Context
There is no issue related as this is just maintenance. Trying to keep each of these limited similar pull requests separated and spread out over time to be sure nothing comes unexpectedly. If something is an issue can can be more easily identified this way as well. I will try to limit these type of pull requests to 1 maybe 2 per release since they are not mission critical. More or less some house cleaning.
I can clean up a couple more files in the client services in this pull request which are IAliasService.cs, IFileService.cs, ModuleService.cs, PackageService.cs, SiteService.cs, SystemService.cs, ThemeService.cs and UserService.cs.
Just reviewing this area a bit and noticed a few files could be cleaned up over time. No need to change too many files at once as requested before so this is very targeted PR. I notice you do one now and again so I thought i would toss one in as well if OK. Maybe 5.1.1 can focus a little more on cleaning up the code base.
I think I had a huge one a long time ago which had spelling corrections and other things like these last pull requests. I think this is that pull request broken down into probably it's 4th or 5th chunk. :)
Thanks for taking time to review all of these latest pull requests. I will be taking a deep look into the latest 5.1.0 issues outlined in the related discussion next week. Hopefully some great news comes soon relating to these final challenges.