Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3977: force reload the page after update the settings. #3988

Closed
wants to merge 1 commit into from

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Mar 14, 2024

No description provided.

@thabaum
Copy link
Contributor

thabaum commented Mar 14, 2024

this does resolve the issue, I had this exact fix, then tested one more time against the new branch and it worked I could not reproduce and adding or removing the forceLoad true setting had no difference which is why I closed it. I did not try testing in Interactive mode... :) Thanks @zyhfish

@sbwalker
Copy link
Member

@zyhfish I am unable to reproduce the issue reported in #3977 in either Static or Interactive render modes. So I am not going to merge this PR unless there is a way to reliably reproduce the problem. It is possible that another PR which has been merged since has already addressed the issue.

@zyhfish
Copy link
Contributor Author

zyhfish commented Mar 17, 2024

Hi @sbwalker , it's easily to be reproduced and I have identified the root cause of this problem, we can setup a meeting to check the issue together if you want. I submitted PR #4006 to fix this issue, I will close this PR as this is just a temp solution.

@zyhfish zyhfish closed this Mar 17, 2024
@zyhfish zyhfish deleted the task/fix-issue-3977 branch March 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants