Issue 436: Add new node sharing test namespace #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamParker
commented
Oct 21, 2019
There was a problem hiding this comment.
I realized after pushing this that I still need to add the namespace to the list to run in the ClojureScript runner function.
| ;; but in any case it should not be more than 1. | ||
| (is (= @tu/side-effect-holder 1) "The constraints on WindSpeed should be evaluated exactly once")) | ||
|
|
||
|
|
There was a problem hiding this comment.
Todo: eliminate this whitespace.
WilliamParker
commented
Oct 21, 2019
| [{:?c {:fact-type ::c}}])))) | ||
|
|
||
|
|
||
| ;; FIXME: Log an issue for this bug and uncomment when it is resolved. Since an :or |
There was a problem hiding this comment.
This fails both before and after #434 so I don't think it is a regression.
|
I've updated the PR according to the todo's I added. |
EthanEChristian
approved these changes
Nov 4, 2019
|
@mrrodriguez I'm going to go ahead and merge this, but if you want to discuss changes, additional tests, etc. later I'm happy to do so - I do see that you self-requested a review a while ago. I just suspect that you're fairly busy right now from offline conversations. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.