Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#264:Provide better exception when unable to resolve class while dese… #476

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

#264:Provide better exception when unable to resolve class while dese… #476

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ab490b
#264:Provide better exception when unable to resolve class while dese…
Jul 19, 2022
afb0604
record -> fact type
EthanEChristian Jul 21, 2022
cff17c5
record -> fact type
EthanEChristian Jul 21, 2022
5252ca5
Correct terminology around class
EthanEChristian Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/clojure/clara/rules/durability/fressian.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,11 @@
([^Reader rdr]
(read-record rdr nil))
([^Reader rdr add-fn]
(let [builder (-> (.readObject rdr) resolve deref)
(let [try-resolve #(if-let [resolved (resolve %)]
resolved
(throw (ex-info (str "Unable to resolve fact type symbol: '" % "'")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessarily a fact, although if the Fressian handlers are being brought in by an IWorkingMemorySerializer implementation they usually will be - the Clara engine nodes have their own handlers anyway: https://github.com/cerner/clara-rules/blob/0.21.2/src/main/clojure/clara/rules/durability/fressian.clj#L393 So this seems OK either way as "fact type symbol" or "record constructor symbol".

{:unresolvable-symbol %})))
builder (-> (.readObject rdr) try-resolve deref)
build-map (.readObject rdr)
m (read-meta rdr)]
(cond-> (builder build-map)
Expand Down