Skip to content

Commit

Permalink
[GR-45371] Move WASM jobs to JDK 21.
Browse files Browse the repository at this point in the history
PullRequest: graal/14872
  • Loading branch information
woess committed Jul 4, 2023
2 parents d6d3586 + 84c4a0f commit 492c601
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 23 deletions.
3 changes: 2 additions & 1 deletion substratevm/mx.substratevm/mx_substratevm.py
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,8 @@ def jvm_unittest(args):
def js_image_test(jslib, bench_location, name, warmup_iterations, iterations, timeout=None, bin_args=None):
bin_args = bin_args if bin_args is not None else []
jsruncmd = [get_js_launcher(jslib)] + bin_args + [join(bench_location, 'harness.js'), '--', join(bench_location, name + '.js'),
'--', '--warmup-iterations=' + str(warmup_iterations),
'--', '--warmup-time=' + str(15_000),
'--warmup-iterations=' + str(warmup_iterations),
'--iterations=' + str(iterations)]
mx.log(' '.join(jsruncmd))

Expand Down
10 changes: 5 additions & 5 deletions vm/ce-release-artifacts.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,27 +62,27 @@
{
"os": "linux",
"arch": "amd64",
"name_template": "{name}-{version}-{os}-{arch}"
"name_template": "{name}-community-{version}-{os}-{arch}"
},
{
"os": "linux",
"arch": "aarch64",
"name_template": "{name}-{version}-{os}-{arch}"
"name_template": "{name}-community-{version}-{os}-{arch}"
},
{
"os": "darwin",
"arch": "amd64",
"name_template": "{name}-{version}-macos-{arch}"
"name_template": "{name}-community-{version}-macos-{arch}"
},
{
"os": "darwin",
"arch": "aarch64",
"name_template": "{name}-{version}-macos-{arch}"
"name_template": "{name}-community-{version}-macos-{arch}"
},
{
"os": "windows",
"arch": "amd64",
"name_template": "{name}-{version}-{os}-{arch}"
"name_template": "{name}-community-{version}-{os}-{arch}"
}
]
},
Expand Down
20 changes: 10 additions & 10 deletions vm/ci/ci_common/common-bench.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,13 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';

local builds = [
# We used to expand `${common_vm_linux}` here to work around some limitations in the version of pyhocon that we use in the CI
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('octane') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-octane-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('jetstream') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-jetstream-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('jetstream2') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-jetstream2-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('micro') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-micro-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('v8js') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-v8js-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('misc') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-misc-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('npm-regex') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-npm-regex-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('octane') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-octane-java' + self.jdk_version + '-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('jetstream') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-jetstream-java' + self.jdk_version + '-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('jetstream2') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-jetstream2-java' + self.jdk_version + '-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('micro') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-micro-java' + self.jdk_version + '-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('v8js') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-v8js-java' + self.jdk_version + '-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('misc') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-misc-java' + self.jdk_version + '-linux-amd64'},
vm_common.bench_ondemand_vm_linux_amd64 + self.vm_bench_js_linux_amd64('npm-regex') + {name: 'ondemand-bench-vm-' + vm.vm_setup.short_name + '-js-npm-regex-java' + self.jdk_version + '-linux-amd64'},

vm_common.bench_daily_vm_linux_amd64 + self.vm_bench_polybench_linux_interpreter + {name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-polybench-linux-amd64', notify_groups:: ['polybench']},
vm_common.bench_daily_vm_linux_amd64 + self.vm_bench_polybench_linux_compiler + {name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-polybench-compiler-linux-amd64', notify_groups:: ['polybench']},
Expand All @@ -294,8 +294,8 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';

vm_common.bench_daily_vm_linux_amd64 + self.vm_bench_polybench_nfi_linux_amd64 + vm.vm_java_20 + {name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-polybench-nfi-java20-linux-amd64', notify_groups:: ['polybench']},

vm_common.bench_daily_vm_linux_amd64 + self.x52_js_bench_compilation_throughput(true) + vm.vm_java_21 + { name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-libgraal-pgo-throughput-js-typescript-java21-linux-amd64' },
vm_common.bench_daily_vm_linux_amd64 + self.x52_js_bench_compilation_throughput(false) + vm.vm_java_21 + { name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-libgraal-no-pgo-throughput-js-typescript-java21-linux-amd64' },
vm_common.bench_daily_vm_linux_amd64 + self.x52_js_bench_compilation_throughput(true) + vm.vm_java_21 + { name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-libgraal-pgo-throughput-js-typescript-java' + self.jdk_version + '-linux-amd64' },
vm_common.bench_daily_vm_linux_amd64 + self.x52_js_bench_compilation_throughput(false) + vm.vm_java_21 + { name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-libgraal-no-pgo-throughput-js-typescript-java' + self.jdk_version + '-linux-amd64' },

vm_common.bench_daily_vm_linux_amd64 + self.vm_bench_js_linux_amd64() + {
# Override `self.vm_bench_js_linux_amd64.run`
Expand All @@ -306,7 +306,7 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';
$.vm_bench_common.upload,
],
timelimit: '45:00',
name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-agentscript-js-java21-linux-amd64',
name: 'daily-bench-vm-' + vm.vm_setup.short_name + '-agentscript-js-java' + self.jdk_version + '-linux-amd64',
notify_groups:: ['javascript'],
},

Expand Down
4 changes: 2 additions & 2 deletions vm/mx.vm/suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"name": "graal-nodejs",
"subdir": True,
"dynamic": True,
"version": "9fb802179bacf9741fb94a9bf13a7bed400cbe62",
"version": "3b4a54988ac3a29aed2cf6f268024346e080768e",
"urls" : [
{"url" : "https://github.com/graalvm/graaljs.git", "kind" : "git"},
]
Expand All @@ -42,7 +42,7 @@
"name": "graal-js",
"subdir": True,
"dynamic": True,
"version": "9fb802179bacf9741fb94a9bf13a7bed400cbe62",
"version": "3b4a54988ac3a29aed2cf6f268024346e080768e",
"urls": [
{"url": "https://github.com/graalvm/graaljs.git", "kind" : "git"},
]
Expand Down
7 changes: 2 additions & 5 deletions wasm/ci/ci.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,17 @@ jdks + wasm_common +
# Gates.
$.jdk17 + $.linux_amd64 + $.gate + $.gate_graalwasm_style + {name: 'gate-graalwasm-style-fullbuild' + self.name_suffix},
$.jdk21 + $.linux_amd64 + $.gate + $.gate_graalwasm_style + {name: 'gate-graalwasm-style-fullbuild' + self.name_suffix},
] + [
$.jdk17 + platform + $.gate + $.gate_graalwasm_full + {environment+: {GATE_TAGS: 'build,wasmtest'}} + {name: 'gate-graalwasm-unittest' + self.name_suffix}
for platform in [$.linux_amd64]
] + [
$.jdk21 + platform + $.gate + $.gate_graalwasm_full + {environment+: {GATE_TAGS: 'build,wasmtest'}} + {name: 'gate-graalwasm-unittest' + self.name_suffix}
for platform in [$.linux_amd64, $.linux_aarch64, $.windows_amd64, $.darwin_aarch64]
] + [
$.jdk21 + $.linux_amd64 + $.gate + $.gate_graalwasm_emsdk_full + {environment+: {GATE_TAGS: 'buildall,wasmextratest'}} + {name: 'gate-graalwasm-extra-unittest' + self.name_suffix},
$.jdk21 + $.linux_amd64 + $.gate + $.gate_graalwasm_emsdk_full + {environment+: {GATE_TAGS: 'buildall,wasmbenchtest'}} + {name: 'gate-graalwasm-benchtest' + self.name_suffix},

$.jdk17 + $.linux_amd64 + $.weekly + $.gate_graalwasm_coverage + {name: 'weekly-graalwasm-coverage' + self.name_suffix},
$.jdk21 + $.linux_amd64 + $.weekly + $.gate_graalwasm_coverage + {name: 'weekly-graalwasm-coverage' + self.name_suffix},

# Benchmark jobs.
$.jdk17 + $.linux_amd64 + $.bench_daily + $.bench_graalwasm_emsdk_full + {
$.jdk21 + $.linux_amd64 + $.bench_daily + $.bench_graalwasm_emsdk_full + {
name: 'bench-graalwasm-c-micro' + self.name_suffix,
environment+: {
BENCH_RUNNER: 'run-c-micro-benchmarks',
Expand Down

0 comments on commit 492c601

Please sign in to comment.