Add unit test

oracle · Feb 2, 2024 · d006869 · d006869
1 parent b51e7bc
commit d006869
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 1 deletion.
diff --git a/...dk.graal.compiler.test/src/jdk/graal/compiler/replacements/test/MethodHandleImplTest.java b/...dk.graal.compiler.test/src/jdk/graal/compiler/replacements/test/MethodHandleImplTest.java
@@ -27,9 +27,20 @@
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
 import java.lang.invoke.MethodType;
+import java.lang.invoke.VarHandle;
 
 import org.junit.Test;
 
+import jdk.graal.compiler.nodes.DeoptimizeNode;
+import jdk.graal.compiler.nodes.ValueNode;
+import jdk.graal.compiler.nodes.graphbuilderconf.GraphBuilderConfiguration;
+import jdk.graal.compiler.nodes.graphbuilderconf.GraphBuilderContext;
+import jdk.graal.compiler.nodes.graphbuilderconf.NodePlugin;
+import jdk.vm.ci.meta.DeoptimizationAction;
+import jdk.vm.ci.meta.DeoptimizationReason;
+import jdk.vm.ci.meta.ResolvedJavaField;
+import jdk.vm.ci.meta.ResolvedJavaMethod;
+
 public class MethodHandleImplTest extends MethodSubstitutionTest {
 
     static final MethodHandle squareHandle;
@@ -63,4 +74,48 @@ public void testIsCompileConstant() {
         testGraph("invokeSquare");
     }
 
+    @Override
+    protected GraphBuilderConfiguration editGraphBuilderConfiguration(GraphBuilderConfiguration conf) {
+        conf.getPlugins().prependNodePlugin(new NodePlugin() {
+            @Override
+            public boolean handleLoadField(GraphBuilderContext b, ValueNode object, ResolvedJavaField field) {
+                if (field.getName().equals("fieldOffset") && b.getGraph().method().getName().equals("incrementThreadCount")) {
+                    // Force a deopt in the testFlock test case
+                    b.add(new DeoptimizeNode(DeoptimizationAction.InvalidateRecompile, DeoptimizationReason.Unresolved));
+                    return true;
+                }
+                return false;
+            }
+        });
+        return super.editGraphBuilderConfiguration(conf);
+    }
+
+    public static class ThreadFlock {
+        private static final VarHandle THREAD_COUNT;
+
+        static {
+            try {
+                MethodHandles.Lookup l = MethodHandles.lookup();
+                THREAD_COUNT = l.findVarHandle(ThreadFlock.class, "threadCount", int.class);
+            } catch (Exception e) {
+                throw new InternalError(e);
+            }
+        }
+
+        private volatile int threadCount;
+
+        public void incrementThreadCount() {
+            THREAD_COUNT.getAndAdd(this, 1);
+        }
+    }
+
+    @Test
+    public void testFlock() {
+        ThreadFlock flock = new ThreadFlock();
+        for (int i = 0; i < 10_000; i++) {
+            flock.incrementThreadCount();
+        }
+        ResolvedJavaMethod method = getResolvedJavaMethod(ThreadFlock.class, "incrementThreadCount");
+        getCode(method);
+    }
 }
diff --git a/compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/java/BytecodeParser.java b/compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/java/BytecodeParser.java
@@ -1886,7 +1886,9 @@ protected Invokable appendInvoke(InvokeKind initialInvokeKind, ResolvedJavaMetho
         if (!parsingIntrinsic() && DeoptALot.getValue(options)) {
             append(new DeoptimizeNode(DeoptimizationAction.None, RuntimeConstraint));
             JavaKind resultType = initialTargetMethod.getSignature().getReturnKind();
-            frameState.pushReturn(resultType, ConstantNode.defaultForKind(resultType, graph));
+            if (resultType != JavaKind.Void) {
+                frameState.pushReturn(resultType, ConstantNode.defaultForKind(resultType, graph));
+            }
             return null;
         }