Use @argFiles to prevent issues with long command line invocations
#3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazar-mitrovic
changed the title
@argFiles to prevent issues with long command line invocations
olpaw
reviewed
Sep 2, 2021
substratevm/src/com.oracle.svm.driver/src/com/oracle/svm/driver/NativeImage.java
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Sep 2, 2021
olpaw
requested changes
Sep 2, 2021
|
Fixes the issue where builder vm invocation would fail on Windows due to classpath length exceeding command line length limit.
lazar-mitrovic
force-pushed
the
arg-file
branch
from
33bcf26
to
7c4a040
Compare
|
olpaw
approved these changes
Sep 6, 2021
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 changes to the Native Image Driver (and its argument parsing mechanism):
@argFilecommand line option to thenative-imagetool. This command is implemented in the same way as injavatool (on JDK9+).NativeImageGeneratorRunneron JDK9+. This enables usage ofclasspath jarworkaround when user encounters a problem with long command line invocation. IMO this change is a bugfix, and should as such be backported to all of the supported versions.Closes #3696.