[GR-44098] Add lambda methods test in debuginfotest #4311

zakkak · 2022-02-10T15:27:21Z

Catches cases like graalvm#355 caused by JDK-8281266

zakkak · 2022-03-23T10:16:31Z

The underlying issue has been fixed in jdk17u-dev and is expected to land in OpenJDK 17.0.4 (July 19 2022). As a result we could consider this PR for inclusion in GraalVM 22.2.0 (July 26, 2022).

oubidar-Abderrahim · 2022-07-18T10:15:01Z

Hi, Thank you for contributing to GraalVM, when this PR is ready for review, please let me know so that I can take care of it and assign it to the proper engineer.

olpaw · 2022-09-20T10:49:19Z

Hi @zakkak,
while already at it, it would be great to also test setting and entering breakpoints in lambdas via

a line breakpoint in the body of the lambda function
method breakpoint on the name of the lambda function

olpaw · 2022-09-20T10:50:54Z

substratevm/src/com.oracle.svm.test/src/hello/Hello.java

@@ -229,4 +229,6 @@ private static void inlineReceiveConstants(byte b, int i, long l, String s, floa
        System.out.println(String.format("q = %g\n", q));
        System.out.println(String.format("t = %s\n", t));
    }
+
+    final static java.util.function.Supplier<String> lambda = () -> "lambdaText";


I do not see any use of that lambda elsewhere. Thus, it is not guaranteed that the reachability analysis will keep it.

Yes, this actually needs to be called by the test program.

adinn

The current check is good. However, as Paul said, we really need this to check breakpoints work at the point of lambda invocation and in the lambda itself. I think it would be best to add that from the start rather than via a follow-up.

zakkak · 2022-09-29T10:05:33Z

Hi all, this is on my to-do list (just not high enough :) )

substratevm/mx.substratevm/testhello.py

olpaw · 2022-11-03T12:38:26Z

@zakkak please fix the merge conflict before we make the internal PR.

zakkak · 2022-11-04T08:04:16Z

@zakkak please fix the merge conflict before we make the internal PR.

Done, should be good to go.

zakkak · 2022-11-09T09:27:30Z

@olpaw could you please create the internal PR for this?

zakkak · 2022-12-02T11:17:11Z

@olpaw @oubidar-Abderrahim I rebased once again to resolve some new conflicts. Please review and merge if OK.

zakkak · 2023-01-30T12:38:40Z

Ping @olpaw @oubidar-Abderrahim ^^

oubidar-Abderrahim · 2023-02-03T16:04:49Z

Hi @zakkak , it seems there are some more conflicts to solve, please do so when possible.
@olpaw Once the conflicts are solved, can we integrate this PR into main, or are there any more changes required?

zakkak · 2023-02-08T12:40:33Z

Hi @zakkak , it seems there are some more conflicts to solve, please do so when possible.

@oubidar-Abderrahim done. Please note that this is the 3rd rebase after the PR's approval. Since this has already been approved, and the conflicts were mostly on line number differences, could you please push it for internal review once the github actions run?

zakkak · 2023-02-14T13:37:13Z

@oubidar-Abderrahim the CI is happy and there are no conflicts, could you please push this to the internal queue?

fniephaus · 2023-06-27T13:12:05Z

Our CI has unfortunately mirrored this to #6895.

fniephaus · 2023-06-27T13:59:29Z

substratevm/mx.substratevm/testhello.py

@@ -453,6 +457,10 @@ def test():
    # print details of Hello type
    exec_string = execute("ptype 'hello.Hello'")
    rexp = [r"type = class hello\.Hello : public java\.lang\.Object {",
+            # r"%spublic:"%spaces_pattern,
+            # r"%sstatic %sjava\.util\.function\.Supplier \*lambda;"%(spaces_pattern, "_z_\." if isolates else ""),


Why is this commented out?

Accidentally, it should just be removed, good catch! Do you want me to fix it here?

Yes please. :)

Catches JDK-8281266

This way we can add methods on top of main without affecting significantly the linenumbers in testhello.py

graalvmbot added the oca-signed label Feb 10, 2022

zakkak force-pushed the debuginfotest-lambda-test branch from 01070f8 to 29738ca Compare February 10, 2022 19:53

zakkak marked this pull request as ready for review July 30, 2022 12:06

zakkak force-pushed the debuginfotest-lambda-test branch from 29738ca to 1d98afd Compare September 20, 2022 09:15

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 20, 2022

zakkak force-pushed the debuginfotest-lambda-test branch from 1d98afd to 436a72c Compare September 20, 2022 10:38

olpaw reviewed Sep 20, 2022

View reviewed changes

olpaw requested a review from adinn September 20, 2022 10:51

adinn reviewed Sep 29, 2022

View reviewed changes

zakkak self-assigned this Sep 29, 2022

zakkak force-pushed the debuginfotest-lambda-test branch 3 times, most recently from d6d2b01 to 6302e97 Compare October 3, 2022 11:36

zakkak requested review from olpaw and adinn October 3, 2022 12:34

olpaw reviewed Oct 3, 2022

View reviewed changes

substratevm/mx.substratevm/testhello.py Outdated Show resolved Hide resolved

olpaw self-requested a review November 3, 2022 12:37

olpaw approved these changes Nov 3, 2022

View reviewed changes

zakkak force-pushed the debuginfotest-lambda-test branch from 6302e97 to b8bb993 Compare November 3, 2022 14:47

adinn approved these changes Nov 7, 2022

View reviewed changes

zakkak force-pushed the debuginfotest-lambda-test branch from b8bb993 to e0b6bce Compare December 2, 2022 11:16

zakkak force-pushed the debuginfotest-lambda-test branch from e0b6bce to 6b42fb0 Compare February 8, 2023 12:38

zakkak force-pushed the debuginfotest-lambda-test branch 2 times, most recently from 7c003a3 to 550da8b Compare February 28, 2023 13:18

fniephaus changed the title ~~Add lambda methods test in debuginfotest~~ [GR-44098] Add lambda methods test in debuginfotest Mar 22, 2023

zakkak added the redhat-interest label May 15, 2023

zakkak force-pushed the debuginfotest-lambda-test branch 2 times, most recently from 26053bb to a1939b1 Compare June 26, 2023 12:18

fniephaus approved these changes Jun 27, 2023

View reviewed changes

fniephaus reviewed Jun 27, 2023

View reviewed changes

zakkak force-pushed the debuginfotest-lambda-test branch from a1939b1 to 4c2436c Compare June 27, 2023 14:23

zakkak added 3 commits June 27, 2023 17:24

Add lambda methods test in debuginfotest

4ee836e

Catches JDK-8281266

debuginfotest: Move main to the end of the file

5708c12

This way we can add methods on top of main without affecting significantly the linenumbers in testhello.py

debuginfotest: Extend lambda method, reference it, and break in it

15bd5b5

zakkak force-pushed the debuginfotest-lambda-test branch from 4c2436c to 15bd5b5 Compare June 27, 2023 14:25

graalvmbot merged commit 15bd5b5 into oracle:master Jun 29, 2023
12 checks passed

zakkak deleted the debuginfotest-lambda-test branch June 29, 2023 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GR-44098] Add lambda methods test in debuginfotest #4311

[GR-44098] Add lambda methods test in debuginfotest #4311

zakkak commented Feb 10, 2022 •

edited

Loading

zakkak commented Mar 23, 2022

oubidar-Abderrahim commented Jul 18, 2022

olpaw commented Sep 20, 2022 •

edited

Loading

olpaw Sep 20, 2022

adinn Sep 29, 2022

adinn left a comment

zakkak commented Sep 29, 2022

olpaw commented Nov 3, 2022

zakkak commented Nov 4, 2022

zakkak commented Nov 9, 2022

zakkak commented Dec 2, 2022

zakkak commented Jan 30, 2023

oubidar-Abderrahim commented Feb 3, 2023

zakkak commented Feb 8, 2023

zakkak commented Feb 14, 2023

fniephaus commented Jun 27, 2023

fniephaus Jun 27, 2023

zakkak Jun 27, 2023 •

edited

Loading

fniephaus Jun 27, 2023

zakkak Jun 27, 2023

[GR-44098] Add lambda methods test in debuginfotest #4311

[GR-44098] Add lambda methods test in debuginfotest #4311

Conversation

zakkak commented Feb 10, 2022 • edited Loading

zakkak commented Mar 23, 2022

oubidar-Abderrahim commented Jul 18, 2022

olpaw commented Sep 20, 2022 • edited Loading

olpaw Sep 20, 2022

Choose a reason for hiding this comment

adinn Sep 29, 2022

Choose a reason for hiding this comment

adinn left a comment

Choose a reason for hiding this comment

zakkak commented Sep 29, 2022

olpaw commented Nov 3, 2022

zakkak commented Nov 4, 2022

zakkak commented Nov 9, 2022

zakkak commented Dec 2, 2022

zakkak commented Jan 30, 2023

oubidar-Abderrahim commented Feb 3, 2023

zakkak commented Feb 8, 2023

zakkak commented Feb 14, 2023

fniephaus commented Jun 27, 2023

fniephaus Jun 27, 2023

Choose a reason for hiding this comment

zakkak Jun 27, 2023 • edited Loading

Choose a reason for hiding this comment

fniephaus Jun 27, 2023

Choose a reason for hiding this comment

zakkak Jun 27, 2023

Choose a reason for hiding this comment

zakkak commented Feb 10, 2022 •

edited

Loading

olpaw commented Sep 20, 2022 •

edited

Loading

zakkak Jun 27, 2023 •

edited

Loading