Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-39313] Avoid NPEs in includeAnnotation when annotationValue is null #4657

Merged
merged 1 commit into from
Jun 21, 2022
Merged

[GR-39313] Avoid NPEs in includeAnnotation when annotationValue is null #4657

merged 1 commit into from
Jun 21, 2022

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jun 20, 2022 •
edited
Loading

Fixes issue introduced in CI runs by #4614

null AnnotationValues may be generated in

graal/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/annotation/AnnotationValue.java

Lines 69 to 71 in d5fae29

if (skipMembers) {
return null;
}

@zakkak zakkak requested a review from loicottet June 20, 2022 11:05
loicottet
loicottet approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@loicottet loicottet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@fniephaus fniephaus changed the title Avoid NPEs in includeAnnotation when annotationValue is null [GR-39313] Avoid NPEs in includeAnnotation when annotationValue is null Jun 21, 2022
@graalvmbot graalvmbot merged commit 5c17b2e into oracle:master Jun 21, 2022
@zakkak zakkak deleted the fix-npe-in-annotations-registration branch June 21, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicottet loicottet loicottet approved these changes

Assignees

@loicottet loicottet

Labels
bug native-image oca-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zakkak @loicottet @graalvmbot