Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-44722] Adjust version strings and properties in Native Image. #6302

Merged
merged 11 commits into from
Mar 29, 2023

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Mar 28, 2023

This PR aligns the output of native-image --version and various java.* properties with the OpenJDK. For GraalVM Community Edition, the output and relavent properties now look like this:

Version string

$ native-image --version
native-image 20 2023-03-21
GraalVM Runtime Environment GraalVM CE (build 20+34-jvmci-23.0-b09)
Substrate VM GraalVM CE (build 20+34, serial gc)

Java properties

java.runtime.name=GraalVM Runtime Environment
java.runtime.version=20+34-jvmci-23.0-b09
java.vendor=GraalVM Community
java.vendor.url=https://www.graalvm.org/
java.vendor.version=GraalVM CE
java.version=20
java.version.date=2023-03-21
java.vm.info=serial gc
java.vm.name=Substrate VM
java.vm.specification.name=Java Virtual Machine Specification
java.vm.specification.vendor=Oracle Corporation
java.vm.specification.version=20
java.vm.vendor=GraalVM Community
java.vm.version=20+34

Note that we plan to further adjust the java.vendor.version (GraalVM CE in the examples above) to include an additional version number, for example GraalVM CE 20+34.1.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 28, 2023
@graalvmbot graalvmbot merged commit 1ec172b into master Mar 29, 2023
@graalvmbot graalvmbot deleted the fniephaus/GR-44722/versions-and-props branch March 29, 2023 01:20
@maxandersen
Copy link

this breaks Quarkus version detection :/

is there a discussion somewhere on rationale for this?

@fniephaus fniephaus changed the title [GR-44722] Adjust version strings and properties. [GR-44722] Adjust version strings and properties in Native Image. Mar 31, 2023
@fniephaus
Copy link
Member

I've added a description to the PR and am working with @jerboaa on fixing the Quarkus version detection. We also need to update the version detection in the Native Build Tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants