-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-44722] Adjust version strings and properties in Native Image. #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Mar 28, 2023
this breaks Quarkus version detection :/ is there a discussion somewhere on rationale for this? |
fniephaus
changed the title
[GR-44722] Adjust version strings and properties.
[GR-44722] Adjust version strings and properties in Native Image.
Mar 31, 2023
I've added a description to the PR and am working with @jerboaa on fixing the Quarkus version detection. We also need to update the version detection in the Native Build Tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the output of
native-image --version
and variousjava.*
properties with the OpenJDK. For GraalVM Community Edition, the output and relavent properties now look like this:Version string
Java properties
Note that we plan to further adjust the
java.vendor.version
(GraalVM CE
in the examples above) to include an additional version number, for exampleGraalVM CE 20+34.1
.