Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-48579] Always use ParseOnce and InlineBeforeAnalysis. #7573

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Oct 9, 2023

The options ParseOnce and InlineBeforeAnalysis have been turned on by default for native images without JIT compilation (i.e., not including Truffle languages) since GraalVM 21.3. For native images with JIT compilation, they have been turned on by default since GraalVM 23.1 (via the separate option ParseOnceJIT).

A lot of old code is no longer necessary when we remove the options: all code that parses bytecode in the hosted universe, together with a lot of hacks that ensure that the bytecode parser behaves the same when parsing in the analysis universe and the hosted universe. This PR does not remove any code yet. It is just the minimal change to render the options ineffective, i.e., the minimal PR that has all the compatibility impact.

Compatibility impact of this PR:

  • Deprecate the option ParseOnce and render it ineffective. Since the option has been around for a long time, we do not want to remove it completely yet. Using the option prints a warning that it no longer has any effect.
  • Deprecate the option ParseOnceJIT and render it ineffective. Even though the option was only introduced to allow internal development and testing, we do not want to remove it completely yet. Using the option prints a warning that it no longer has any effect.
  • Deprecate the option InlineBeforeAnalysis and render it ineffective. Since the option has been around for a long time, we do not want to remove it completely yet. Using the option prints a warning that it no longer has any effect.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 9, 2023
@zakkak
Copy link
Collaborator

zakkak commented Oct 10, 2023

Hi @christianwimmer , Quarkus is OK with this change. We are no longer using ParseOnce for GraalVM versions >= 22.2
and we have already deprecated the option to disable InlineBeforeAnalysis.

Thanks for the heads up.

@graalvmbot graalvmbot merged commit 692f52a into master Oct 22, 2023
12 checks passed
@graalvmbot graalvmbot deleted the cwi/GR-48579-ParseOnce branch October 22, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants