Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-41614] Move resource registration to beforeAnalysis phase #7670

Merged
merged 54 commits into from
Oct 26, 2023
Merged

[GR-41614] Move resource registration to beforeAnalysis phase #7670

merged 54 commits into from
Oct 26, 2023

Commits on Oct 24, 2023

  1. Move resource registration to beforeAnalysis phase

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a180a4b View commit details
    Browse the repository at this point in the history

  2. Try to speed resource traversing by introducing parallelism

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    252861c View commit details
    Browse the repository at this point in the history

  3. Change function that public API uses to register resource

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ee5f501 View commit details
    Browse the repository at this point in the history

  4. Add resource registration through API without patterns

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f3e5980 View commit details
    Browse the repository at this point in the history

  5. Try to open modules and decide whether resource comes from jar

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7865a6c View commit details
    Browse the repository at this point in the history

  6. Replace CharsetSubstitution resource adding

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    705835d View commit details
    Browse the repository at this point in the history

  7. Change addResource function to check whether the entry is directory o… 

    …r not
    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    eaafc3d View commit details
    Browse the repository at this point in the history

  8. Extract resource adding from beforeAnalysis to duringSetup in Truffle… 

    …BaseFeature
    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    82fdd40 View commit details
    Browse the repository at this point in the history

  9. Extract bunndles registration from pattern based addResources

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5e71750 View commit details
    Browse the repository at this point in the history

  10. Replace resource Bundles registration with non-pattern-based implemen… 

    …tation
    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1468ef1 View commit details
    Browse the repository at this point in the history

  11. Add null pointer check for module classLoader

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    55c9af1 View commit details
    Browse the repository at this point in the history

  12. Add .properties extension to resourceBundle name

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5d53612 View commit details
    Browse the repository at this point in the history

  13. Add module lookup map

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5633755 View commit details
    Browse the repository at this point in the history

  14. Add unnamed module case

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fa166d8 View commit details
    Browse the repository at this point in the history

  15. Move resource adding to duringSetup when the RuntimeResourceSupport i… 

    …s added to singletones
    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2b762d9 View commit details
    Browse the repository at this point in the history

  16. Try to match resource pattern

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b4ca2f2 View commit details
    Browse the repository at this point in the history

  17. Cover the case when resource has condition

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8a7f024 View commit details
    Browse the repository at this point in the history

  18. Add conditional resource directory registration test

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7a34bb3 View commit details
    Browse the repository at this point in the history

  19. Refactor adding content to directory resource

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8b02c19 View commit details
    Browse the repository at this point in the history

  20. Replace pairs with records to get more semantic

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f2a4fbc View commit details
    Browse the repository at this point in the history

  21. Get content for directories inside jar

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f49fe93 View commit details
    Browse the repository at this point in the history

  22. Add possiblity to register resource for various conditions

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a5ca553 View commit details
    Browse the repository at this point in the history

  23. Prevent registration of same resources multiple times

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1f28251 View commit details
    Browse the repository at this point in the history

  24. Resolve conflicts

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    130eb2a View commit details
    Browse the repository at this point in the history

  25. Remove exceptions that could not be thrown from method signature

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    18a1797 View commit details
    Browse the repository at this point in the history

  26. Remove unused import from mx file

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    08167ef View commit details
    Browse the repository at this point in the history

  27. Revert locale argument for prepareBundle function

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    12aa181 View commit details
    Browse the repository at this point in the history

  28. Add missing throw when using VMError

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    de5d307 View commit details
    Browse the repository at this point in the history

  29. Replace findModule with Class.class.getModule for java.base scenario

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fb8105d View commit details
    Browse the repository at this point in the history

  30. Remove comments from prepareBundle

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    69646bc View commit details
    Browse the repository at this point in the history

  31. Add null check guard for findModule

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9c59901 View commit details
    Browse the repository at this point in the history

  32. Remove redudant functions and improve duplicates checking

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    03854b2 View commit details
    Browse the repository at this point in the history

  33. Register negative query directories

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9b9ed1f View commit details
    Browse the repository at this point in the history

  34. Fix package export from module

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    167a727 View commit details
    Browse the repository at this point in the history

  35. Remove redudant parameters from resource registration functions

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    620f813 View commit details
    Browse the repository at this point in the history

  36. Remove sufficient prints

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2e76995 View commit details
    Browse the repository at this point in the history

  37. Cover case when same resource name can occur in multiple bundles

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1635c2b View commit details
    Browse the repository at this point in the history

  38. Restructure code for better readability

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    52d9e72 View commit details
    Browse the repository at this point in the history

  39. Add synchronization for alreadyAddedResources check

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0f90072 View commit details
    Browse the repository at this point in the history

  40. Cleanup code

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    17f84cc View commit details
    Browse the repository at this point in the history

  41. Convert ResorucePattern class to record

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    45c27ed View commit details
    Browse the repository at this point in the history

  42. Remove debugg context since it is not used anymore

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    30e5c86 View commit details
    Browse the repository at this point in the history

  43. Add explanation for shouldRegisterResource function

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c898d38 View commit details
    Browse the repository at this point in the history

  44. Add function that is never used just to pass gates

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0853a1c View commit details
    Browse the repository at this point in the history

  45. Replace module export with module open access

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    56bdd98 View commit details
    Browse the repository at this point in the history

  46. Update imports according to changes on master

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e1807e0 View commit details
    Browse the repository at this point in the history

  47. Inline function and remove passing null for findModule function

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ec0913f View commit details
    Browse the repository at this point in the history

  48. Avoid using synchronized block all the time

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9de65c8 View commit details
    Browse the repository at this point in the history

  49. Replace multiple calls of string transformation with function

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2da282f View commit details
    Browse the repository at this point in the history

  50. Extract directory registration handling form registerResoruce function

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    4b9c4d7 View commit details
    Browse the repository at this point in the history

  51. Rebase and fix imports

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f54f22c View commit details
    Browse the repository at this point in the history

  52. Rename includeAll variable to includeCurrent

    @dnestoro
    dnestoro committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9f793ce View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Use Resources#registerIOException instead of ignoring exception

    @dnestoro
    dnestoro committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e006dd4 View commit details
    Browse the repository at this point in the history

  2. Revert overridden prepareBundle function because it can be called fro… 

    …m other places
    @dnestoro
    dnestoro committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b552181 View commit details
    Browse the repository at this point in the history