Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-47922] Improve list of experimental options. #7720

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Nov 2, 2023

This PR adds additional migration messages that work across options (e.g., -H:IncludeResources can be replaced with a reflect-config.json) and ensures that -H:Log and other experimental options that are not of type HostedOptionKey are listed correctly.

$ native-image -H:Log=registerResource -H:Path=$(pwd) -H:ReflectionConfigurationFiles=$(pwd)/reflect-config.json -H:IncludeResources=$(pwd) -m jdk.httpserver
Warning: The option '-H:Path=/home/fniephaus/dev/graalvm/graal/substratevm' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:ReflectionConfigurationFiles=/home/fniephaus/dev/graalvm/graal/substratevm/reflect-config.json' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:Log=registerResource' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:IncludeResources=/home/fniephaus/dev/graalvm/graal/substratevm' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: Please re-evaluate whether any experimental option is required, and either remove or unlock it. The build output lists all active experimental options, including where they come from and possible alternatives. If you think an experimental option should be considered as stable, please file an issue.
========================================================================================================================
GraalVM Native Image: Generating 'jdk.httpserver' (executable)...
========================================================================================================================
[1/8] Initializing...                                                                                    (4.7s @ 0.20GB)
...
------------------------------------------------------------------------------------------------------------------------
 4 experimental option(s) unlocked:
 - '-H:ReflectionConfigurationFiles': Use a reflect-config.json in your META-INF/native-image/<groupID>/<artifactID> directory instead. (origin(s): command line)
 - '-H:Path': Use the '-o' option instead. (origin(s): command line)
 - '-H:Log' (origin(s): command line)
 - '-H:IncludeResources': Use a resource-config.json in your META-INF/native-image/<groupID>/<artifactID> directory instead. (origin(s): command line)
------------------------------------------------------------------------------------------------------------------------

Relates to #7370.

@graalvmbot graalvmbot force-pushed the fniephaus/GR-47922/exp-opts-improvements branch from afb0ce4 to 6b9173a Compare November 6, 2023 15:56
@graalvmbot graalvmbot merged commit 04f57e0 into master Nov 6, 2023
12 checks passed
@graalvmbot graalvmbot deleted the fniephaus/GR-47922/exp-opts-improvements branch November 6, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants