Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-48152] Remove DisableSubstitutionReturnTypeCheck option #8010

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

graalvmbot
Copy link
Collaborator

The option was only added to temporary disable the new return type check (0ceaa57). It was needed to give downstream projects the possibility to adopt while keep running them in our own CI.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 12, 2023
@zapster zapster requested a review from zakkak December 12, 2023 15:33
@zapster
Copy link
Member

zapster commented Dec 12, 2023

@zakkak FYI. Quarkus should be ready according to the comments in #7340.

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, IIRC Quarkus and its extensions never used DisableSubstitutionReturnTypeCheck.

Thanks for the heads up.

@graalvmbot graalvmbot closed this Dec 19, 2023
@graalvmbot graalvmbot merged commit 512022d into master Dec 19, 2023
12 checks passed
@graalvmbot graalvmbot deleted the je/svm-remove-subst-ret-type-flag-GR-48152 branch December 19, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants