[GR-58239] Enforce that substitution target classes are static when they are inner classes. #9733
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TargetClass
annotated target classes must not be non-static inner classes, because the reference to the outer-class instance is a synthetic field in such inner classes and can cause problems.I also played around with disallowing inner classes completely, but that would be a too intrusive change. We have several inner target classes ourselfs, and external libraries might have them too. There is no need to break them.