Remove MBean-related reflection entries from undertow-core #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why CI failed. |
This was referenced Jan 5, 2023
wilkinsona
force-pushed
the
fix-undertow-mbean-server-problem
branch
from
a01289d to
b8a2e70
Compare
|
@melix any idea why this build fails? |
2 tasks
|
@wilkinsona please try to rebase your PR and restart CI. This error should be fixed |
2 tasks
undertow-core's metadata contains entries for various MBean-related classes. This metadata causes a call to ManagementFactory.getPlatformMBeanServer() to fail with a javax.management.openmbean.OpenDataException. It would appear that the metadata is sufficient for the bootstrapping of the MBean server to take a different code path to normal and this path fails. Removing the metadata fixes ManagementFactory.getPlatformMBeanServer() and has no adverse effects on the existing tests for undertow-core.
wilkinsona
force-pushed
the
fix-undertow-mbean-server-problem
branch
from
b8a2e70 to
a0f54de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to the problem with Hibernate that #113 fixed, Undertow's metadata contains entries for various MBean-related classes. This metadata causes a call to
ManagementFactory.getPlatformMBeanServer()to fail with ajavax.management.openmbean.OpenDataException. It would appear that the metadata is sufficient for the bootstrapping of the MBean server to take a different code path to normal and this path fails. This PR removes the offending metadata which fixesManagementFactory.getPlatformMBeanServer()and has no adverse effects on the existing tests for hibernate-core.Checklist before merging
No new tests have been added but the existing tests are unaffected by the changes.