Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update library-and-framework-list.json with OCI APM Related details #333

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Update library-and-framework-list.json with OCI APM Related details #333

merged 3 commits into from
Jul 6, 2023

Conversation

smutalik
Copy link
Contributor

@smutalik smutalik commented Jul 3, 2023 •
edited
Loading

What does this PR do?

Checklist before merging

  • I have considered including reachability metadata directly in the library or the framework (see this)
  • I have properly formatted metadata files (see this)
  • I have added thorough tests (see this)

@smutalik smutalik requested a review from a team as a code owner July 3, 2023 11:58
@smutalik smutalik requested a review from msupic July 3, 2023 11:58
@dnestoro dnestoro requested a review from fniephaus July 3, 2023 12:00
fniephaus
fniephaus approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

fniephaus
fniephaus requested changes Jul 3, 2023
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON check fails because the entries are not sorted. Could you please make sure the JSON is sorted alphabetically?

@smutalik
Copy link
Contributor Author

smutalik commented Jul 4, 2023

@fniephaus - I have updated the PR with the alphabetically sorted JSON file.

fniephaus
fniephaus approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM and passes the relevant gate. The failing check is unrelated, we should get that fixed very soon.

@fniephaus fniephaus force-pushed the patch-1 branch 2 times, most recently from 25d1e02 to bea78a0 Compare July 6, 2023 09:25
@fniephaus fniephaus merged commit 6a3d96c into oracle:master Jul 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fniephaus fniephaus fniephaus approved these changes

@msupic msupic Awaiting requested review from msupic msupic was automatically assigned from oracle/graalvm-reachability-maintainer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smutalik @fniephaus