Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKE OSS release v1.28.0 #452

Merged
merged 13 commits into from
Feb 16, 2024

Conversation

l-technicore
Copy link
Member

@l-technicore l-technicore commented Feb 8, 2024

Change Log:

  • Upgraded k8s to v1.28
  • NSG rule management for CCM loadbalancers and respective e2e tests
  • Add validation if loadbalancer subnets are empty and new unit test cases
  • Bug fix for topology collision error in CSI node driver
  • Bug fixes and follow-up improvements for the NSG rule management feature
  • CSI controller GRPCs now use parent contexts, new unit tests and logging improvements
  • Updated timeouts for CSI ControllerPublish/ControllerUnpublish/ControllerExpand calls
  • Fix for FSS controller nil pointer reference causing panic
  • Enabling static FSS Intransit encryption Tests for ARM
  • Support UHP volumes
  • CVE fixes
  • E2E and other doc updates

E2E results:

FOCUS=[cloudprovider] (excluding NSG and UHP E2Es)

ccm-csi-e2e-1.28.0-output.txt

Summarizing 2 Failures:

[Fail] Backup/Restore [cloudprovider][storage][fvp] [It] should be possible to backup a volume and restore the created backup
/Users/lalit/go/src/github.com/oracle/oci-cloud-controller-manager/test/e2e/framework/pod_util.go:294

[Fail] flex volume driver [cloudprovider][storage][fvd] [It] should be possible to mount a volume
/Users/lalit/go/src/github.com/oracle/oci-cloud-controller-manager/test/e2e/framework/pod_util.go:294

Ran 101 of 105 Specs in 19976.261 seconds
FAIL! -- 99 Passed | 2 Failed | 0 Pending | 4 Skipped
--- FAIL: TestE2E (19976.30s)
FAIL

Ginkgo ran 1 suite in 5h35m13.261198809s
Test Suite Failed
AMD Failed

FOCUS=[2_previous_failed_tests] (excluding NSG and UHP E2Es)

ccm-csi-e2e-1.28.0-output-2.txt

Ran 2 of 105 Specs in 455.129 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 103 Skipped
PASS

Ginkgo ran 1 suite in 7m50.929879091s
Test Suite Passed
AMD tests are Successful

FOCUS=[managedNsg]

ccm-csi-e2e-1.28.0-output-nsg.txt

Ran 1 of 118 Specs in 406.474 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 117 Skipped
PASS

Ginkgo ran 1 suite in 8m32.228058532s
Test Suite Passed
AMD tests are Successful

FOCUS=[UHP]

ccm-csi-e2e-1.28.0-output-uhp-2.txt

Summarizing 1 Failure:

[Fail] CSI Ultra High Performance Volumes [cloudprovider][storage][csi][uhp] [It] Expand PVC VolumeSize from 50Gi to 100Gi and asserts size, file existence and file corruptions for Paravirtualized UHP volume
/Users/lalit/go/src/github.com/oracle/oci-cloud-controller-manager/test/e2e/framework/pod_util.go:219

Ran 12 of 118 Specs in 3123.798 seconds
FAIL! -- 11 Passed | 1 Failed | 0 Pending | 106 Skipped
--- FAIL: TestE2E (3123.85s)
FAIL

Ginkgo ran 1 suite in 52m41.245369771s
Test Suite Failed
AMD Failed

* One failure due to a known issue from block storage which is currenlty being released to production regions.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 8, 2024
@l-technicore l-technicore self-assigned this Feb 8, 2024
@coveralls
Copy link

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 7898187063

Details

  • -1671 of 2096 (20.28%) changed or added relevant lines in 27 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+1.6%) to 30.875%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/oci/client/utils.go 0 1 0.0%
pkg/cloudprovider/providers/oci/instances.go 5 7 71.43%
pkg/csi-util/utils.go 0 2 0.0%
pkg/cloudprovider/providers/oci/load_balancer_security_lists.go 0 3 0.0%
pkg/csi/driver/fss_node.go 0 3 0.0%
pkg/csi/driver/fss_controller.go 9 16 56.25%
pkg/oci/client/client.go 0 8 0.0%
pkg/flexvolume/block/driver.go 0 13 0.0%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 114 134 85.07%
pkg/cloudprovider/providers/oci/load_balancer_util.go 2 26 7.69%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/providers/oci/load_balancer_util.go 1 84.13%
pkg/csi/driver/fss_node.go 1 0.0%
pkg/flexvolume/block/driver.go 1 6.9%
pkg/csi/driver/bv_node.go 4 2.13%
pkg/cloudprovider/providers/oci/load_balancer.go 6 26.83%
Totals Coverage Status
Change from base Build 7758216582: 1.6%
Covered Lines: 3923
Relevant Lines: 12706

💛 - Coveralls

@dhananjay-ng
Copy link
Contributor

Changes for my commit looks good to me.

@l-technicore l-technicore force-pushed the oke-oss-release-v1.28.0 branch 3 times, most recently from 2a98531 to 2d9af99 Compare February 8, 2024 13:35
@l-technicore l-technicore force-pushed the oke-oss-release-v1.28.0 branch from 2d9af99 to fad178e Compare February 14, 2024 08:06
@l-technicore l-technicore merged commit 189982e into oracle:master Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants