Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging support for IngressClass #103

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add tagging support for IngressClass #103

merged 1 commit into from
Oct 22, 2024

Conversation

piyush-tiwari
Copy link
Member

- Add support for defined and freeform tags via IngressClass annotations
- Swap opc-retry-token in UpdateLoadbalancer call in IngressClass controller logic for an ifMatch
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11453906424

Details

  • 99 of 145 (68.28%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 65.312%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/loadbalancer/loadbalancer.go 1 19 5.26%
pkg/controllers/ingressclass/ingressclass.go 68 96 70.83%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/ingressclass/ingressclass.go 2 58.74%
Totals Coverage Status
Change from base Build 11162346840: -0.2%
Covered Lines: 2604
Relevant Lines: 3987

💛 - Coveralls

@piyush-tiwari piyush-tiwari merged commit e74b161 into main Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants