Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKE-26958 Web application firewall integration #14

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

Inbaraj-S
Copy link
Contributor

@Inbaraj-S Inbaraj-S commented Aug 2, 2023

  • Added support for annotation oci-native-ingress.oraclecloud.com/waf-policy-ocid which enables user to add firewall policy id to IngressClass. It helps us create and add firewall to the corresponding LB.
  • Post creation of firewall, we add the corresponding firewall ocid to the ingressclass via oci-native-ingress.oraclecloud.com/firewall-id.
  • OKE-27261-Fixed-multi-path-bug

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 2, 2023
@Inbaraj-S Inbaraj-S force-pushed the web-application-firewall-integration branch from 2830184 to 130dc2b Compare August 7, 2023 09:27
@coveralls
Copy link

coveralls commented Aug 7, 2023

Pull Request Test Coverage Report for Build 5884005797

  • 64 of 156 (41.03%) changed or added relevant lines in 8 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.5%) to 56.651%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/backend/backend.go 4 5 80.0%
pkg/controllers/routingpolicy/util.go 19 21 90.48%
pkg/controllers/ingressclass/ingressclass.go 21 26 80.77%
pkg/controllers/routingpolicy/routingpolicy.go 6 11 54.55%
pkg/controllers/ingress/ingress.go 14 21 66.67%
pkg/util/testutil.go 0 16 0.0%
pkg/util/util.go 0 27 0.0%
pkg/server/server.go 0 29 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/ingressclass/ingressclass.go 1 57.34%
pkg/server/server.go 1 4.5%
pkg/controllers/routingpolicy/routingpolicy.go 2 35.32%
Totals Coverage Status
Change from base Build 5883643548: -0.5%
Covered Lines: 2057
Relevant Lines: 3631

💛 - Coveralls

@Inbaraj-S Inbaraj-S force-pushed the web-application-firewall-integration branch from 40b60b4 to 2588de2 Compare August 9, 2023 06:39
@Inbaraj-S Inbaraj-S requested a review from nirpai August 9, 2023 08:51
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/controllers/ingressclass/ingressclass.go Outdated Show resolved Hide resolved
@Inbaraj-S Inbaraj-S force-pushed the web-application-firewall-integration branch from c4283d0 to 527025c Compare August 16, 2023 21:24
@Inbaraj-S Inbaraj-S merged commit ad04c22 into feature-branch Aug 17, 2023
Inbaraj-S added a commit that referenced this pull request Aug 22, 2023
* Update lb resource tagging (#12)
* OKE-24944 - Ingressclassparameters update flow (#13)
* OKE-26958 Web application firewall integration (#14)
* OKE-27261-Fixed-multi-path-bug
* Update GettingStarted.md
@Inbaraj-S Inbaraj-S deleted the web-application-firewall-integration branch November 22, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants