Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKE-27032 Flannel Support #28

Merged
merged 3 commits into from
Nov 7, 2023
Merged

OKE-27032 Flannel Support #28

merged 3 commits into from
Nov 7, 2023

Conversation

Inbaraj-S
Copy link
Contributor

@Inbaraj-S Inbaraj-S commented Oct 4, 2023 •
edited
Loading

Added support for flannel CNI. Accepts Nodeport Service for Flannel CNI and adds nodes as backend based on externalTrafficPolicy set on service.
Added a new parameter in deployment - cluster-id to check for cluster details.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 4, 2023
@Inbaraj-S Inbaraj-S marked this pull request as ready for review October 4, 2023 09:09
@Inbaraj-S Inbaraj-S requested a review from nirpai October 4, 2023 09:10
nirpai
nirpai reviewed Oct 9, 2023
View reviewed changes
pkg/server/server.go Outdated Show resolved Hide resolved
@Inbaraj-S Inbaraj-S force-pushed the OKE-27032-Flannel-Support branch from 607aa04 to 4aa5195 Compare October 11, 2023 22:40
@coveralls
Copy link

coveralls commented Oct 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6780920755

  • 168 of 350 (48.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+8.1%) to 65.264%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeBackend/nodeBackend.go 157 237 66.24%
pkg/util/util.go 1 103 0.97%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/backend/backend.go 1 62.04%
Totals Coverage Status
Change from base Build 6456082883: 8.1%
Covered Lines: 2234
Relevant Lines: 3423
💛 - Coveralls

@Inbaraj-S Inbaraj-S force-pushed the OKE-27032-Flannel-Support branch 2 times, most recently from 08b7d64 to 296b636 Compare October 19, 2023 04:05
@Inbaraj-S Inbaraj-S force-pushed the OKE-27032-Flannel-Support branch 4 times, most recently from a9a2dbd to 81bf8bc Compare November 6, 2023 10:04
nirpai
nirpai previously approved these changes Nov 7, 2023
View reviewed changes
@Inbaraj-S Inbaraj-S force-pushed the OKE-27032-Flannel-Support branch from 81bf8bc to 014779e Compare November 7, 2023 06:25
@Inbaraj-S Inbaraj-S force-pushed the OKE-27032-Flannel-Support branch from 014779e to 306c26b Compare November 7, 2023 06:39
@Inbaraj-S Inbaraj-S merged commit 642ca75 into main Nov 7, 2023
4 checks passed
@Inbaraj-S Inbaraj-S deleted the OKE-27032-Flannel-Support branch November 22, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirpai nirpai nirpai approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Inbaraj-S @coveralls @nirpai