Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to disable TLS on the backend. #44

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Add support to disable TLS on the backend. #44

merged 2 commits into from
Mar 22, 2024

Conversation

robo-cap
Copy link
Member

@robo-cap robo-cap commented Mar 4, 2024

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 4, 2024
@coveralls
Copy link

coveralls commented Mar 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8390516922

Details

  • 21 of 27 (77.78%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 65.38%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/state/ingressstate.go 8 14 57.14%
Totals Coverage Status
Change from base Build 7795472675: 0.08%
Covered Lines: 2253
Relevant Lines: 3446
💛 - Coveralls

@robo-cap robo-cap mentioned this pull request Mar 14, 2024
Closed
@Inbaraj-S
Copy link
Contributor

E2e test in progress in backend.

@Inbaraj-S
Copy link
Contributor

++ @nirpai
E2e tested successfully.

'
testcase name="[It] Validate TLS support for ingress Run ingress TLS tests after resource initialization Test TLS through kubernetes secret and certificate [ingress, tlsLbTerminationTests]" classname="Ingress E2E suite" status="passed" time="387.50551225"
'

@Inbaraj-S Inbaraj-S requested review from nirpai and Inbaraj-S March 22, 2024 08:42
@Inbaraj-S Inbaraj-S merged commit 46ad7f3 into oracle:main Mar 22, 2024
3 checks passed
@Inbaraj-S Inbaraj-S mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirpai nirpai nirpai approved these changes

@Inbaraj-S Inbaraj-S Awaiting requested review from Inbaraj-S

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robo-cap @coveralls @Inbaraj-S @nirpai