Fix finalizer removal logic for ingresses #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Pull Request Test Coverage Report for Build 10072714911Details
💛 - Coveralls |
piyush-tiwari
force-pushed
the
dev-piytiwar
branch
from
4dbd95e to
dc6bac2
Compare
nirpai
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OCI Native Ingress Controller does not remove its guarding finalizer from Ingresses in these scenarios -
Ingress.Spec.IngressClassNameto an IngressClass that is not handled by OCI NICIngress.Spec.IngressClassName, possibly because the IngressClass was deleted before Ingresses attached to it wereThis fix adds code to remove finalizers in such scenarios, marking the Ingress free to delete as the backing LB resources do not exist.