OpenGrok trying to use RCSRepository to retrieve past revisions of files in CVS

[aerofeev2k]

Hi,

I'm not sure if it's a bug or a misconfiguration on our side.

We indexed a CVS-checked out tree with CVS repository on the same box. Indexing went file, we can see files contents (xref) and even History. /etc/opengrok/configuration.xml shows that OpenGrok recognized the repository as CVS.

But when we click any older revision in the History, for any file, we're getting "Error reading file" page, and Tomcat shows errors like below, which seems to indicate that in this case OpenGrok is trying to use RCSRepository to pull older revisions. What could be the reason? This is opengrok-1.7.30.

06-Apr-2022 20:52:04.471 SEVERE [http-nio-8080-exec-8] org.opengrok.indexer.history.RCSRepository.getHistoryGet Failed to retrieve revision 1.4 of file.cpp
        java.io.IOException: Parse error: Parse error at line 1, column 20717.  Encountered: 14c426179f7ab4567
                at org.opengrok.indexer.history.RCSRepository.wrapInIOException(RCSRepository.java:117)
                at org.opengrok.indexer.history.RCSget.<init>(RCSget.java:69)
                at org.opengrok.indexer.history.RCSRepository.getHistoryGet(RCSRepository.java:76)
                at org.opengrok.indexer.history.Repository.getHistoryGet(Repository.java:258)
                at org.opengrok.indexer.history.HistoryGuru.getRevision(HistoryGuru.java:335)
                at org.apache.jsp.list_jsp._jspService(list_jsp.java:960)
                at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
                at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:777)
                at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
                at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:380)
                at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:328)
                at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:777)
                at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:223)
                at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:158)
                at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
                at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:185)
                at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:158)
                at org.opengrok.web.CookieFilter.doFilter(CookieFilter.java:50)
                at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:185)
                at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:158)
                at org.opengrok.web.AuthorizationFilter.doFilter(AuthorizationFilter.java:95)
                at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:185)
                at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:158)
                at org.opengrok.web.StatisticsFilter.doFilter(StatisticsFilter.java:67)
                at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:185)
                at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:158)
                at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
                at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
                at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:542)
                at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:119)
                at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
                at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:690)

Thanks,
Andrei

[aerofeev2k]

Is this because CVSRepository doesn't define a getHistoryGet(OutputStream out, String parent, String base, String rev)? So RCSRepository::getHistoryGet() ends up being called instead?

[vladak]

Given that CVSRepository extends RCSRepository that sounds plausible. CVSRepository overrides public InputStream getHistoryGet(String parent, String basename, String rev) however does not implement abstract boolean getHistoryGet(OutputStream out, String parent, String basename, String rev); used in this case so it is taken from the parent class. This seems like a bug.

[aerofeev2k]

Added public boolean getHistoryGet(OutputStream out, String parent, String basename, String rev) to CVSRepository.java, and that did the trick. Thanks.

[vladak]

pull requests are welcome